From: Ted Kremenek <kremenek@apple.com>
Date: Fri, 22 Feb 2008 18:41:59 +0000 (+0000)
Subject: Punt on unifying symbolic lvalues.  This won't be needed for many checkers.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f700df2638bf0e2a5bc3785267a3a923be6fd88e;p=clang

Punt on unifying symbolic lvalues.  This won't be needed for many checkers.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@47489 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/Analysis/GRSimpleVals.cpp b/Analysis/GRSimpleVals.cpp
index 775d099ab7..04a13e3703 100644
--- a/Analysis/GRSimpleVals.cpp
+++ b/Analysis/GRSimpleVals.cpp
@@ -225,11 +225,12 @@ RVal GRSimpleVals::EvalEQ(ValueManager& ValMgr, LVal L, LVal R) {
         return nonlval::SymIntConstraintVal(C);
       }
       
-      // FIXME: Implement unification
-      return UnknownVal();
-        //assert (!isa<lval::SymbolVal>(R) && "FIXME: Implement unification.");
-      
-      break;
+      // FIXME: Implement == for lval Symbols.  This is mainly useful
+      //  in iterator loops when traversing a buffer, e.g. while(z != zTerm).
+      //  Since this is not useful for many checkers we'll punt on this for 
+      //  now.
+       
+      return UnknownVal();      
     }
       
     case lval::DeclValKind:
@@ -278,7 +279,12 @@ RVal GRSimpleVals::EvalNE(ValueManager& ValMgr, LVal L, LVal R) {
         return nonlval::SymIntConstraintVal(C);
       }
       
-      assert (!isa<lval::SymbolVal>(R) && "FIXME: Implement sym !=.");
+      // FIXME: Implement != for lval Symbols.  This is mainly useful
+      //  in iterator loops when traversing a buffer, e.g. while(z != zTerm).
+      //  Since this is not useful for many checkers we'll punt on this for 
+      //  now.
+      
+      return UnknownVal();
       
       break;
     }