From: Eli Friedman Date: Tue, 27 May 2008 04:20:05 +0000 (+0000) Subject: Generalize the float type generation code, and specifically fix the X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f6a943e047f541619a2202f9e43b20b3d7c0a96d;p=clang Generalize the float type generation code, and specifically fix the codegen of X86 long double. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@51578 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/CodeGen/CodeGenTypes.cpp b/lib/CodeGen/CodeGenTypes.cpp index b640c912e5..aa0d2ed053 100644 --- a/lib/CodeGen/CodeGenTypes.cpp +++ b/lib/CodeGen/CodeGenTypes.cpp @@ -161,6 +161,21 @@ void CodeGenTypes::CollectObjCIvarTypes(ObjCInterfaceDecl *ObjCClass, } } +static const llvm::Type* getTypeForFormat(const llvm::fltSemantics * format) { + if (format == &llvm::APFloat::IEEEsingle) + return llvm::Type::FloatTy; + if (format == &llvm::APFloat::IEEEdouble) + return llvm::Type::DoubleTy; + if (format == &llvm::APFloat::IEEEquad) + return llvm::Type::FP128Ty; + if (format == &llvm::APFloat::PPCDoubleDouble) + return llvm::Type::PPC_FP128Ty; + if (format == &llvm::APFloat::x87DoubleExtended) + return llvm::Type::X86_FP80Ty; + assert(9 && "Unknown float format!"); + return 0; +} + const llvm::Type *CodeGenTypes::ConvertNewType(QualType T) { const clang::Type &Ty = *T.getCanonicalType(); @@ -195,13 +210,12 @@ const llvm::Type *CodeGenTypes::ConvertNewType(QualType T) { return llvm::IntegerType::get( static_cast(Context.getTypeSize(T))); - case BuiltinType::Float: return llvm::Type::FloatTy; + case BuiltinType::Float: + return getTypeForFormat(Context.Target.getFloatFormat()); case BuiltinType::Double: - return (Context.Target.getDoubleFormat() == &llvm::APFloat::IEEEdouble) ? - llvm::Type::DoubleTy : llvm::Type::FloatTy; + return getTypeForFormat(Context.Target.getDoubleFormat()); case BuiltinType::LongDouble: - // FIXME: mapping long double onto double. - return llvm::Type::DoubleTy; + return getTypeForFormat(Context.Target.getLongDoubleFormat()); } break; } diff --git a/test/CodeGen/long-double-x86.c b/test/CodeGen/long-double-x86.c new file mode 100644 index 0000000000..88ac0c9268 --- /dev/null +++ b/test/CodeGen/long-double-x86.c @@ -0,0 +1,4 @@ +// RUN: clang %s -emit-llvm -o - -triple=i686-apple-darwin9 | grep x86_fp80 + +long double x = 0; +int checksize[sizeof(x) == 12 ? 1 : -1];