From: Rodger Combs <rodger.combs@gmail.com>
Date: Sat, 23 Mar 2019 13:30:32 +0000 (-0500)
Subject: fontselect: add overflow check
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f62f5f0d05480ea5d8f8dd50bae55243b1cfb90b;p=libass

fontselect: add overflow check
---

diff --git a/libass/ass_fontselect.c b/libass/ass_fontselect.c
index 9c4bb3b..e9748de 100644
--- a/libass/ass_fontselect.c
+++ b/libass/ass_fontselect.c
@@ -786,14 +786,14 @@ get_font_info(FT_Library lib, FT_Face face, ASS_FontProviderMetaData *info)
             ass_utf16be_to_utf8(buf, sizeof(buf), (uint8_t *)name.string,
                                 name.string_len);
 
-            if (name.name_id == TT_NAME_ID_FULL_NAME) {
+            if (name.name_id == TT_NAME_ID_FULL_NAME && num_fullname < MAX_FULLNAME) {
                 fullnames[num_fullname] = strdup(buf);
                 if (fullnames[num_fullname] == NULL)
                     goto error;
                 num_fullname++;
             }
 
-            if (name.name_id == TT_NAME_ID_FONT_FAMILY) {
+            if (name.name_id == TT_NAME_ID_FONT_FAMILY && num_family < MAX_FULLNAME) {
                 families[num_family] = strdup(buf);
                 if (families[num_family] == NULL)
                     goto error;