From: Zeev Suraski Date: Thu, 25 Nov 1999 16:11:34 +0000 (+0000) Subject: Fix bug #2817 - assignments to string offsets could erronously modify unrelated strings X-Git-Tag: PRE_RETURN_REF_PATCH~249 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f62a08c2ae79a28f288924e38427f7e14499771d;p=php Fix bug #2817 - assignments to string offsets could erronously modify unrelated strings --- diff --git a/Zend/zend_execute.c b/Zend/zend_execute.c index 12dee19586..8394954975 100644 --- a/Zend/zend_execute.c +++ b/Zend/zend_execute.c @@ -688,6 +688,8 @@ static inline void zend_fetch_dimension_address(znode *result, znode *op1, znode convert_to_long(&tmp); offset = &tmp; } + SEPARATE_ZVAL(container_ptr); + container = *container_ptr; Ts[result->u.var].EA.str = container; PZVAL_LOCK(container); Ts[result->u.var].EA.offset = offset->value.lval;