From: Steven R. Loomis <srl@icu-project.org>
Date: Thu, 23 Aug 2012 20:17:13 +0000 (+0000)
Subject: ICU-9499 add author column  for 0.12
X-Git-Tag: milestone-59-0-1~3645
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f60d0e159eec9dc8774536726bd1dbd4e6e7eb25;p=icu

ICU-9499 add author column  for 0.12

X-SVN-Rev: 32222
---

diff --git a/tools/trac/IcuCodeTools/0.12/icucodetools/htdocs/js/review.js b/tools/trac/IcuCodeTools/0.12/icucodetools/htdocs/js/review.js
index 0c6c7181ca6..87db57b3830 100644
--- a/tools/trac/IcuCodeTools/0.12/icucodetools/htdocs/js/review.js
+++ b/tools/trac/IcuCodeTools/0.12/icucodetools/htdocs/js/review.js
@@ -4,7 +4,7 @@
      var cst = document.getElementById("changesettable");
      var trs=cst.getElementsByTagName("tr");
      for( i=1 ; i < trs.length ; i++ ) {
-        var sec = trs[i].getElementsByTagName('td')[0];
+	var sec = trs[i].getElementsByTagName('td')[1]; // [0] is 'author', [1] is section.
         var brk = sec.getElementsByTagName('a');
         for(j=0;j<brk.length;j++) {
            var bri = brk[j];
diff --git a/tools/trac/IcuCodeTools/0.12/icucodetools/review.py b/tools/trac/IcuCodeTools/0.12/icucodetools/review.py
index 9e2b5d1a7f9..93d59ade0e7 100755
--- a/tools/trac/IcuCodeTools/0.12/icucodetools/review.py
+++ b/tools/trac/IcuCodeTools/0.12/icucodetools/review.py
@@ -240,6 +240,7 @@ class ReviewModule(Component):
             revcount = revcount + 1
             revision = {}
             revision['rev'] =  tag.a(rev, req.href.changeset(rev))
+            revision['author'] = chgset.author
             revision['num'] =  rev
             revision['comment'] =  message #wiki_to_oneliner( message, self.env, db, shorten=False )
             rbranches = revision['branches'] = []
diff --git a/tools/trac/IcuCodeTools/0.12/icucodetools/templates/review.html b/tools/trac/IcuCodeTools/0.12/icucodetools/templates/review.html
index 53c09de557f..696464bf7bd 100644
--- a/tools/trac/IcuCodeTools/0.12/icucodetools/templates/review.html
+++ b/tools/trac/IcuCodeTools/0.12/icucodetools/templates/review.html
@@ -27,6 +27,7 @@
     <thead>
       <tr>
 	<th>r</th>
+	<th>author</th>
 	<th>section(s)</th>
 	<th>comment</th>
       </tr>
@@ -37,6 +38,9 @@
 	  <th>
 	    <a href="${href.changeset(rev.num)}">r${rev.num}</a>
 	  </th>
+	  <td>
+	    ${rev.author}
+	  </td>
 	  <td>
 	    <!-- sections -->
 	    <py:for each="branch in rev.branches">