From: Shane F. Carr <shane@unicode.org>
Date: Tue, 8 Mar 2022 03:17:05 +0000 (-0800)
Subject: ICU-21527 Assert pattern equality instead of object equality
X-Git-Tag: release-71-rc~29
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f57ef9ebf72d889e9b93be90fbc020fae0e374ae;p=icu

ICU-21527 Assert pattern equality instead of object equality
---

diff --git a/icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberRegressionTests.java b/icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberRegressionTests.java
index 37c2cc0f25d..92e04cfb2cc 100644
--- a/icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberRegressionTests.java
+++ b/icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberRegressionTests.java
@@ -1537,12 +1537,6 @@ public class NumberRegressionTests extends TestFmwk {
         // trip properly.  Test stream in/out integrity too.
         Locale[] avail = NumberFormat.getAvailableLocales();
         for (int i=0; i<avail.length; ++i) {
-            if ((avail[i].getLanguage().equals("ji") || avail[i].getLanguage().equals("bm")) &&
-                    logKnownIssue(
-                        "21527",
-                        "Remove bad currency test case in NumberRegressionTests.java")) {
-                continue;
-            }
             for (int j=0; j<3; ++j) {
                 NumberFormat nf;
                 switch (j) {
@@ -1566,7 +1560,8 @@ public class NumberRegressionTests extends TestFmwk {
                     // Currency does not travel with the pattern string
                     f2.setCurrency(df.getCurrency());
                 }
-                if (!df.equals(f2)) {
+                // ICU-21527: Test the pattern but not the whole DecimalFormat for equality
+                if (!df.toPattern().equals(f2.toPattern())) {
                     errln("FAIL: " + avail[i] + " #" + j + " -> \"" + pat +
                           "\" -> \"" + f2.toPattern() + "\" for case " + j);
                 }