From: Quentin Colombet <quentin.colombet@gmail.com>
Date: Fri, 11 Oct 2019 20:22:57 +0000 (+0000)
Subject: [GISel][CallLowering] Enable vector support in argument lowering
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f4daa70c5499fc1009d62e233079008dc998d6cf;p=llvm

[GISel][CallLowering] Enable vector support in argument lowering

The exciting code is actually already enough to handle the splitting
of vector arguments but we were lacking a test case.

This commit adds a test case for vector argument lowering involving
splitting and enable the related support in call lowering.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@374589 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/CodeGen/GlobalISel/CallLowering.cpp b/lib/CodeGen/GlobalISel/CallLowering.cpp
index d05e2091c71..ed4d22578f6 100644
--- a/lib/CodeGen/GlobalISel/CallLowering.cpp
+++ b/lib/CodeGen/GlobalISel/CallLowering.cpp
@@ -198,14 +198,12 @@ bool CallLowering::handleAssignments(CCState &CCInfo,
       unsigned NumParts = TLI->getNumRegistersForCallingConv(
           F.getContext(), F.getCallingConv(), CurVT);
       if (NumParts > 1) {
-        if (CurVT.isVector())
-          return false;
         // For now only handle exact splits.
         if (NewVT.getSizeInBits() * NumParts != CurVT.getSizeInBits())
           return false;
       }
 
-      // For incoming arguments (return values), we could have values in
+      // For incoming arguments (physregs to vregs), we could have values in
       // physregs (or memlocs) which we want to extract and copy to vregs.
       // During this, we might have to deal with the LLT being split across
       // multiple regs, so we have to record this information for later.
@@ -221,7 +219,7 @@ bool CallLowering::handleAssignments(CCState &CCInfo,
             return false;
         } else {
           // We're handling an incoming arg which is split over multiple regs.
-          // E.g. returning an s128 on AArch64.
+          // E.g. passing an s128 on AArch64.
           ISD::ArgFlagsTy OrigFlags = Args[i].Flags[0];
           Args[i].OrigRegs.push_back(Args[i].Regs[0]);
           Args[i].Regs.clear();
diff --git a/test/CodeGen/AArch64/GlobalISel/irtranslator-split-vector-arg.ll b/test/CodeGen/AArch64/GlobalISel/irtranslator-split-vector-arg.ll
new file mode 100644
index 00000000000..ef74cdb4aad
--- /dev/null
+++ b/test/CodeGen/AArch64/GlobalISel/irtranslator-split-vector-arg.ll
@@ -0,0 +1,22 @@
+; NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+; RUN: llc -global-isel -global-isel-abort=1 %s -stop-after=irtranslator -o - | FileCheck %s
+target triple = "aarch64-apple-ios"
+
+; Check that we correctly split %arg into two vector registers of
+; size <2 x i64>.
+define hidden fastcc <4 x float> @foo(<4 x i64> %arg) unnamed_addr #0 {
+  ; CHECK-LABEL: name: foo
+  ; CHECK: bb.1.bb:
+  ; CHECK:   liveins: $q0, $q1
+  ; CHECK:   [[COPY:%[0-9]+]]:_(<2 x s64>) = COPY $q0
+  ; CHECK:   [[COPY1:%[0-9]+]]:_(<2 x s64>) = COPY $q1
+  ; CHECK:   [[CONCAT_VECTORS:%[0-9]+]]:_(<4 x s64>) = G_CONCAT_VECTORS [[COPY]](<2 x s64>), [[COPY1]](<2 x s64>)
+  ; CHECK:   [[UITOFP:%[0-9]+]]:_(<4 x s32>) = G_UITOFP [[CONCAT_VECTORS]](<4 x s64>)
+  ; CHECK:   $q0 = COPY [[UITOFP]](<4 x s32>)
+  ; CHECK:   RET_ReallyLR implicit $q0
+bb:
+  %tmp = uitofp <4 x i64> %arg to <4 x float>
+  ret <4 x float> %tmp
+}
+
+attributes #0 = { nounwind readnone }