From: Yasuo Ohgaki <yohgaki@php.net>
Date: Tue, 8 Sep 2015 09:50:40 +0000 (+0900)
Subject: Add URL rewrite issue note.
X-Git-Tag: php-7.1.0alpha1~1217
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f4c9deb4522b08252110ae5c56a89b09b62522c3;p=php

Add URL rewrite issue note.
---

diff --git a/ext/session/session.c b/ext/session/session.c
index be86dcae7f..fb7d29d050 100644
--- a/ext/session/session.c
+++ b/ext/session/session.c
@@ -1498,6 +1498,10 @@ PHPAPI void php_session_reset_id(void) /* {{{ */
 	}
 
 	if (APPLY_TRANS_SID) {
+		/* FIXME: Restting vars are required when
+		   session is stop/start/regenerated. However,
+		   php_url_scanner_reset_vars() resets all vars
+		   including other URL rewrites set by elsewhere. */
 		/* php_url_scanner_reset_vars(); */
 		php_url_scanner_add_var(PS(session_name), strlen(PS(session_name)), ZSTR_VAL(PS(id)), ZSTR_LEN(PS(id)), 1);
 	}