From: Fred Drake <fdrake@acm.org>
Date: Fri, 12 Apr 2002 19:32:07 +0000 (+0000)
Subject: Warn people away from PyModule_GetDict(), but not too strongly.
X-Git-Tag: v2.3c1~5996
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f495ef7466e1955206d792d6c8e215d98bbc3db0;p=python

Warn people away from PyModule_GetDict(), but not too strongly.
(The real issue is whether modules can benefit from an alternate
implementation strategy rather than using a dictionary.  We should migrate
away from direct dictionary manipulation to allow more room for Jeremy to
flex the implementation with changes in globals lookup.)
---

diff --git a/Doc/api/concrete.tex b/Doc/api/concrete.tex
index f175ff12d7..976292468d 100644
--- a/Doc/api/concrete.tex
+++ b/Doc/api/concrete.tex
@@ -2111,6 +2111,9 @@ There are only a few functions special to module objects.
   namespace; this object is the same as the \member{__dict__}
   attribute of the module object.  This function never fails.
   \withsubitem{(module attribute)}{\ttindex{__dict__}}
+  It is recommended extensions use other \cfunction{PyModule_*()}
+  and \cfunction{PyObject_*()} functions rather than directly
+  manipulate a module's \member{__dict__}.
 \end{cfuncdesc}
 
 \begin{cfuncdesc}{char*}{PyModule_GetName}{PyObject *module}