From: Andrey Hristov <andrey@php.net>
Date: Fri, 12 Jan 2007 20:26:35 +0000 (+0000)
Subject: add a sticky note
X-Git-Tag: RELEASE_1_0_0RC1~280
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f483a60f3abbd2ec920726ed52779ebd31d928ce;p=php

add a sticky note
---

diff --git a/ext/mysqli/mysqli_api.c b/ext/mysqli/mysqli_api.c
index b73c4081bc..18afcc5b62 100644
--- a/ext/mysqli/mysqli_api.c
+++ b/ext/mysqli/mysqli_api.c
@@ -686,6 +686,11 @@ PHP_FUNCTION(mysqli_stmt_fetch)
 	if (!ret) {
 #endif
 		for (i = 0; i < stmt->result.var_cnt; i++) {
+			/*
+			  QQ: Isn't it quite better to call zval_dtor(). What if the user has
+			  assigned a resource, or an array to the bound variable? We are going
+			  to leak probably. zval_dtor() will handle also Unicode/Non-unicode mode.
+			*/
 			/* Even if the string is of length zero there is one byte alloced so efree() in all cases */
 			if (Z_TYPE_P(stmt->result.vars[i]) == IS_STRING) {
 				efree(stmt->result.vars[i]->value.str.val);