From: Tom Lane Date: Mon, 21 Jan 2019 16:28:03 +0000 (-0500) Subject: Revert "Fix under-quoted filename pattern in pgbench TAP test." X-Git-Tag: REL_12_BETA1~911 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f4593bd2ff0376fbc56dd1b384c7d51e1a7062f0;p=postgresql Revert "Fix under-quoted filename pattern in pgbench TAP test." This reverts commit 458a1244f1fcf407874482a93b7631ecf5303d6e. It has portability problems on Windows, which will require a little bit of research to fix. Discussion: https://postgr.es/m/20202.1548035461@sss.pgh.pa.us --- diff --git a/src/bin/pgbench/t/001_pgbench_with_server.pl b/src/bin/pgbench/t/001_pgbench_with_server.pl index 17323e6ca5..c87748086a 100644 --- a/src/bin/pgbench/t/001_pgbench_with_server.pl +++ b/src/bin/pgbench/t/001_pgbench_with_server.pl @@ -879,10 +879,9 @@ sub check_pgbench_logs my ($prefix, $nb, $min, $max, $re) = @_; - my $qprefix = quotemeta($prefix); - my @logs = glob "$qprefix.*"; + my @logs = glob "$prefix.*"; ok(@logs == $nb, "number of log files"); - ok(grep(/^$qprefix\.\d+(\.\d+)?$/, @logs) == $nb, "file name format"); + ok(grep(/^$prefix\.\d+(\.\d+)?$/, @logs) == $nb, "file name format"); my $log_number = 0; for my $log (sort @logs)