From: Jim Jagielski <jim@apache.org>
Date: Fri, 8 Jul 2005 15:58:46 +0000 (+0000)
Subject: Good suggestion from a private Email. name changes.
X-Git-Tag: 2.1.7~35
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f4572909ff96047555bb53500a9098d0832cb20a;p=apache

Good suggestion from a private Email. name changes.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@209827 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/CHANGES b/CHANGES
index c085918ee5..e00b3f9c0e 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,11 +1,9 @@
 Changes with Apache 2.1.7
   [Remove entries to the current 2.0 section below, when backported]
 
-  *) Add additional SSLSessionCache option, 'internal', which makes
-     mod_ssl just use OpenSSL's own internal session ID cache. Useful
-     when one needs to disable any external, shared caches but
-     requires the server to send non-null session IDs.
-     [Jim Jagielski]
+  *) Add additional SSLSessionCache option, 'nonenotnull', which is
+     similar to 'none' (disabling any external shared cache) but forces
+     OpenSSL to provide a non-null session ID.  [Jim Jagielski]
 
   *) Add httxt2dbm to support/ for creating RewriteMap DBM Files.
      [Paul Querna]
diff --git a/docs/manual/mod/mod_ssl.html.en b/docs/manual/mod/mod_ssl.html.en
index a3c81554d8..fb5fbe1605 100644
--- a/docs/manual/mod/mod_ssl.html.en
+++ b/docs/manual/mod/mod_ssl.html.en
@@ -1532,12 +1532,11 @@ The following four storage <em>type</em>s are currently supported:</p>
     using certain browsers, particularly if client certificates are
     enabled.  This setting is not recommended.</p></li>
 
-<li><code>internal</code>
+<li><code>nonenotnull</code>
 
     <p>This disables any global/inter-process Session Cache.  However
-    it does allow OpenSSL to use its own internal session cache. This in
-    mainly useful in situations where a global cache cannot be used
-    but the client requires a non-null session ID.</p></li>
+    it does force OpenSSL to send a non-null session ID to
+    accommodate buggy clients that require one.</p></li>
 
 <li><code>dbm:/path/to/datafile</code>
 
diff --git a/docs/manual/mod/mod_ssl.xml b/docs/manual/mod/mod_ssl.xml
index c93e5b1918..a184e85f66 100644
--- a/docs/manual/mod/mod_ssl.xml
+++ b/docs/manual/mod/mod_ssl.xml
@@ -412,12 +412,11 @@ The following four storage <em>type</em>s are currently supported:</p>
     using certain browsers, particularly if client certificates are
     enabled.  This setting is not recommended.</p></li>
 
-<li><code>internal</code>
+<li><code>nonenotnull</code>
 
     <p>This disables any global/inter-process Session Cache.  However
-    it does allow OpenSSL to use its own internal session cache. This in
-    mainly useful in situations where a global cache cannot be used
-    but the client requires a non-null session ID.</p></li>
+    it does force OpenSSL to send a non-null session ID to
+    accommodate buggy clients that require one.</p></li>
 
 <li><code>dbm:/path/to/datafile</code>
 
diff --git a/modules/ssl/mod_ssl.c b/modules/ssl/mod_ssl.c
index 66017302e6..0fcbd52283 100644
--- a/modules/ssl/mod_ssl.c
+++ b/modules/ssl/mod_ssl.c
@@ -83,7 +83,7 @@ static const command_rec ssl_config_cmds[] = {
                 "or `exec:/path/to/cgi_program')")
     SSL_CMD_SRV(SessionCache, TAKE1,
                 "SSL Session Cache storage "
-                "(`none', `internal', `dbm:/path/to/file')")
+                "(`none', `nonenotnull', `dbm:/path/to/file')")
 #if defined(HAVE_OPENSSL_ENGINE_H) && defined(HAVE_ENGINE_INIT)
     SSL_CMD_SRV(CryptoDevice, TAKE1,
                 "SSL external Crypto Device usage "
diff --git a/modules/ssl/ssl_engine_config.c b/modules/ssl/ssl_engine_config.c
index 304516021b..a28d3bafa5 100644
--- a/modules/ssl/ssl_engine_config.c
+++ b/modules/ssl/ssl_engine_config.c
@@ -1001,8 +1001,8 @@ const char *ssl_cmd_SSLSessionCache(cmd_parms *cmd,
         mc->nSessionCacheMode      = SSL_SCMODE_NONE;
         mc->szSessionCacheDataFile = NULL;
     }
-    else if (strcEQ(arg, "internal")) {
-        mc->nSessionCacheMode      = SSL_SCMODE_OPENSSL_INTERNAL;
+    else if (strcEQ(arg, "nonenotnull")) {
+        mc->nSessionCacheMode      = SSL_SCMODE_NONE_NOT_NULL;
         mc->szSessionCacheDataFile = NULL;
     }
     else if ((arglen > 4) && strcEQn(arg, "dbm:", 4)) {
diff --git a/modules/ssl/ssl_private.h b/modules/ssl/ssl_private.h
index 02cebee1fc..fcaa8204e3 100644
--- a/modules/ssl/ssl_private.h
+++ b/modules/ssl/ssl_private.h
@@ -260,7 +260,7 @@ typedef enum {
     SSL_SCMODE_DBM   = 1,
     SSL_SCMODE_SHMCB = 3,
     SSL_SCMODE_DC    = 4,
-    SSL_SCMODE_OPENSSL_INTERNAL = 5
+    SSL_SCMODE_NONE_NOT_NULL = 5
 } ssl_scmode_t;
 
 /*