From: Tom Lane Date: Mon, 17 Mar 2014 01:43:40 +0000 (-0400) Subject: Fix advertised dispsize for libpq's sslmode connection parameter. X-Git-Tag: REL9_4_BETA1~334 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f4051e363c1757a5fa05825a361d9dd0e54508bc;p=postgresql Fix advertised dispsize for libpq's sslmode connection parameter. "8" was correct back when "disable" was the longest allowed value, but since "verify-full" was added, it should be "12". Given the lack of complaints, I wouldn't be surprised if nobody is actually using these values ... but still, if they're in the API, they should be right. Noticed while pursuing a different problem. It's been wrong for quite a long time, so back-patch to all supported branches. --- diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c index dedb6e74f1..da8335e680 100644 --- a/src/interfaces/libpq/fe-connect.c +++ b/src/interfaces/libpq/fe-connect.c @@ -251,7 +251,7 @@ static const internalPQconninfoOption PQconninfoOptions[] = { * to exclude them since none of them are mandatory. */ {"sslmode", "PGSSLMODE", DefaultSSLMode, NULL, - "SSL-Mode", "", 8, /* sizeof("disable") == 8 */ + "SSL-Mode", "", 12, /* sizeof("verify-full") == 12 */ offsetof(struct pg_conn, sslmode)}, {"sslcompression", "PGSSLCOMPRESSION", "1", NULL,