From: Brian Gesiak Date: Wed, 10 Jan 2018 20:23:45 +0000 (+0000) Subject: [Driver] Test for correct '--version' suggestion X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f3d739418b264a3967db2f56aee3df4ed2f8d45b;p=clang [Driver] Test for correct '--version' suggestion Summary: The `llvm::OptTable::findNearest` bug fixed in https://reviews.llvm.org/D41873 manifested itself as the following erroneous message when invoking Clang: ``` clang -version clang-6.0: error: unknown argument '-version', did you mean 'version'? ``` Add a test to catch any future regressions to the now correct behavior, which asks "did you mean '--version'?". Test Plan: `check-clang` Reviewers: v.g.vassilev, teemperor, ruiu, jroelofs, yamaguchi Reviewed By: v.g.vassilev Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D41912 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@322220 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/test/Driver/unknown-arg.c b/test/Driver/unknown-arg.c index aebf84c561..053731535c 100644 --- a/test/Driver/unknown-arg.c +++ b/test/Driver/unknown-arg.c @@ -1,6 +1,6 @@ // RUN: not %clang %s -cake-is-lie -%0 -%d -HHHH -munknown-to-clang-option -print-stats -funknown-to-clang-option -### 2>&1 | \ // RUN: FileCheck %s -// RUN: not %clang %s -stdlibs=foo -hell -### 2>&1 | \ +// RUN: not %clang %s -stdlibs=foo -hell -version -### 2>&1 | \ // RUN: FileCheck %s --check-prefix=DID-YOU-MEAN // RUN: %clang_cl -cake-is-lie -%0 -%d -HHHH -munknown-to-clang-option -print-stats -funknown-to-clang-option -### -c -- %s 2>&1 | \ // RUN: FileCheck %s --check-prefix=CL @@ -22,6 +22,7 @@ // CHECK: error: unknown argument: '-funknown-to-clang-option' // DID-YOU-MEAN: error: unknown argument '-stdlibs=foo', did you mean '-stdlib=foo'? // DID-YOU-MEAN: error: unknown argument '-hell', did you mean '-help'? +// DID-YOU-MEAN: error: unknown argument '-version', did you mean '--version'? // CL: warning: unknown argument ignored in clang-cl: '-cake-is-lie' // CL: warning: unknown argument ignored in clang-cl: '-%0' // CL: warning: unknown argument ignored in clang-cl: '-%d'