From: Ted Kremenek <kremenek@apple.com>
Date: Sat, 31 May 2008 00:27:00 +0000 (+0000)
Subject: Correctly preserve the order between -F and -I options.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f372111960934c639af8f5885b5b26954960d847;p=clang

Correctly preserve the order between -F and -I options.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@51803 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/Driver/clang.cpp b/Driver/clang.cpp
index 84df9de971..7a61145c66 100644
--- a/Driver/clang.cpp
+++ b/Driver/clang.cpp
@@ -870,13 +870,23 @@ static void AddEnvVarPaths(const char *Name, HeaderSearch &Headers) {
 /// HeaderSearch object.
 static void InitializeIncludePaths(const char *Argv0, HeaderSearch &Headers,
                                    FileManager &FM, const LangOptions &Lang) {
-  // Handle -F... options.
-  for (unsigned i = 0, e = F_dirs.size(); i != e; ++i)
-    AddPath(F_dirs[i], Angled, false, true, true, Headers);
+  // Handle -I... and -F... options, walking the lists in parallel.
+  unsigned Iidx = 0, Fidx = 0;
+  while (Iidx < I_dirs.size() && Fidx < F_dirs.size()) {
+    if (I_dirs.getPosition(Iidx) < F_dirs.getPosition(Fidx)) {
+      AddPath(I_dirs[Iidx], Angled, false, true, false, Headers);
+      ++Iidx;
+    } else {
+      AddPath(F_dirs[Fidx], Angled, false, true, true, Headers);
+      ++Fidx;
+    }
+  }
   
-  // Handle -I... options.
-  for (unsigned i = 0, e = I_dirs.size(); i != e; ++i)
-    AddPath(I_dirs[i], Angled, false, true, false, Headers);
+  // Consume what's left from whatever list was longer.
+  for (; Iidx != I_dirs.size(); ++Iidx)
+    AddPath(I_dirs[Iidx], Angled, false, true, false, Headers);
+  for (; Fidx != F_dirs.size(); ++Fidx)
+    AddPath(F_dirs[Fidx], Angled, false, true, true, Headers);
   
   // Handle -idirafter... options.
   for (unsigned i = 0, e = idirafter_dirs.size(); i != e; ++i)