From: Georg Brandl <georg@python.org>
Date: Sat, 17 Mar 2012 15:58:05 +0000 (+0100)
Subject: Closes #14306: clarify expensiveness of try-except and update code snippet
X-Git-Tag: v2.7.4rc1~958^2~9
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f354f8e369e1e903d489e6dbac01f94d905dc022;p=python

Closes #14306: clarify expensiveness of try-except and update code snippet
---

diff --git a/Doc/faq/design.rst b/Doc/faq/design.rst
index 962b4ef4fc..25c72db89b 100644
--- a/Doc/faq/design.rst
+++ b/Doc/faq/design.rst
@@ -297,8 +297,9 @@ use the ``join()`` function from the string module, which allows you to write ::
 How fast are exceptions?
 ------------------------
 
-A try/except block is extremely efficient.  Actually catching an exception is
-expensive.  In versions of Python prior to 2.0 it was common to use this idiom::
+A try/except block is extremely efficient if no exceptions are raised.  Actually
+catching an exception is expensive.  In versions of Python prior to 2.0 it was
+common to use this idiom::
 
    try:
        value = mydict[key]
@@ -309,11 +310,10 @@ expensive.  In versions of Python prior to 2.0 it was common to use this idiom::
 This only made sense when you expected the dict to have the key almost all the
 time.  If that wasn't the case, you coded it like this::
 
-   if mydict.has_key(key):
+   if key in mydict:
        value = mydict[key]
    else:
-       mydict[key] = getvalue(key)
-       value = mydict[key]
+       value = mydict[key] = getvalue(key)
 
 .. note::