From: Rafael Espindola <rafael.espindola@gmail.com>
Date: Thu, 28 May 2015 20:19:31 +0000 (+0000)
Subject: Avoid warnings when building without asserts.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f3344cdffb1ef2e94fdb9cf1f1af37e4c16eb1c8;p=llvm

Avoid warnings when building without asserts.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@238479 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/MC/ELFObjectWriter.cpp b/lib/MC/ELFObjectWriter.cpp
index 11eef6489f1..958591b1266 100644
--- a/lib/MC/ELFObjectWriter.cpp
+++ b/lib/MC/ELFObjectWriter.cpp
@@ -961,19 +961,14 @@ void ELFObjectWriter::computeSymbolTable(
   for (ELFSymbolData &MSD : ExternalSymbolData) {
     MSD.StringIndex = StrTabBuilder.getOffset(MSD.Name);
     MSD.Symbol->setIndex(Index++);
-    MCSymbolData &Data = MSD.Symbol->getData();
-    assert(((Data.getFlags() & ELF_STB_Global) ||
-            (Data.getFlags() & ELF_STB_Weak)) &&
-           "External symbol requires STB_GLOBAL or STB_WEAK flag");
     WriteSymbol(Writer, MSD, Layout);
-    assert(MCELF::GetBinding(Data) != ELF::STB_LOCAL);
+    assert(MCELF::GetBinding(MSD.Symbol->getData()) != ELF::STB_LOCAL);
   }
   for (ELFSymbolData &MSD : UndefinedSymbolData) {
     MSD.StringIndex = StrTabBuilder.getOffset(MSD.Name);
     MSD.Symbol->setIndex(Index++);
-    MCSymbolData &Data = MSD.Symbol->getData();
     WriteSymbol(Writer, MSD, Layout);
-    assert(MCELF::GetBinding(Data) != ELF::STB_LOCAL);
+    assert(MCELF::GetBinding(MSD.Symbol->getData()) != ELF::STB_LOCAL);
   }
 
   uint64_t SecEnd = OS.tell();