From: Sebastien GODARD <sysstat@users.noreply.github.com>
Date: Fri, 21 Sep 2018 11:44:45 +0000 (+0200)
Subject: Fix #189: [: n: unexpected operator
X-Git-Tag: v12.1.1~7
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f2f27905570996d79b0130d6feee89993c08d81f;p=sysstat

Fix #189: [: n: unexpected operator

On some systems, installing sysstat lead to the following error:

elif [ -d /etc ]; then \
        install -m 755 sysstat /etc/rc.sysstat; \
        if [ "n" == "n" ]; then \
                if [ -x "" ]; then \
                        cd /etc &&  --add rc.sysstat; \
                else \
                        [ -d /etc/rc2.d ] || mkdir -p /etc/rc2.d; \
                        [ -d /etc/rc3.d ] || mkdir -p /etc/rc3.d; \
                        [ -d /etc/rc5.d ] || mkdir -p /etc/rc5.d; \
                        cd /etc/rc2.d && ln -s -f ../rc.sysstat S01sysstat; \
                        cd /etc/rc3.d && ln -s -f ../rc.sysstat S01sysstat; \
                        cd /etc/rc5.d && ln -s -f ../rc.sysstat S01sysstat; \
                fi \
        fi \
fi
/bin/sh: 9: [: n: unexpected operator

This is because POSIX sh does not support == for string equality.
This is supported only by bash.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>
---

diff --git a/Makefile.in b/Makefile.in
index a204022..333f6e2 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -434,7 +434,7 @@ endif
 		$(INSTALL_DATA) cron/sysstat-summary.timer $(DESTDIR)$(SYSTEMD_UNIT_DIR); \
 	elif [ -d $(DESTDIR)$(INIT_DIR) ]; then \
 		$(INSTALL_BIN) sysstat $(DESTDIR)$(INIT_DIR)/sysstat; \
-		if [ "$(COPY_ONLY)" == "n" ]; then \
+		if [ "$(COPY_ONLY)" = "n" ]; then \
 			if [ -x "$(CHKCONFIG)" ]; then \
 				cd $(DESTDIR)$(INIT_DIR) && $(CHKCONFIG) --add sysstat; \
 			else \
@@ -448,7 +448,7 @@ endif
 		fi \
 	elif [ -d $(DESTDIR)$(RC_DIR) ]; then \
 		$(INSTALL_BIN) sysstat $(DESTDIR)$(RC_DIR)/rc.sysstat; \
-		if [ "$(COPY_ONLY)" == "n" ]; then \
+		if [ "$(COPY_ONLY)" = "n" ]; then \
 			if [ -x "$(CHKCONFIG)" ]; then \
 				cd $(DESTDIR)$(RC_DIR) && $(CHKCONFIG) --add rc.sysstat; \
 			else \