From: Joe Orton <jorton@apache.org>
Date: Thu, 11 Oct 2007 14:13:40 +0000 (+0000)
Subject: * server/util_filter.c (ap_filter_flush): Tweak comment; no functional
X-Git-Tag: 2.3.0~1334
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f29b0683a2899d6f8f1a957013f6ac5954081dbe;p=apache

* server/util_filter.c (ap_filter_flush): Tweak comment; no functional
change.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@583830 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/server/util_filter.c b/server/util_filter.c
index a59dcd8b80..1b9e84112c 100644
--- a/server/util_filter.c
+++ b/server/util_filter.c
@@ -582,12 +582,11 @@ AP_DECLARE_NONSTD(apr_status_t) ap_filter_flush(apr_bucket_brigade *bb,
 
     rv = ap_pass_brigade(f, bb);
 
-    /* apr_brigade_write et all require that the flush callback
-     * ensures the brigade is empty upon return; otherwise the brigade
-     * may be left with a transient bucket whose contents have fallen
-     * out of scope.  Call cleanup here unconditionally, to avoid the
-     * issue even in error cases where some filter fails and leaves a
-     * non-empty brigade. */
+    /* Before invocation of the flush callback, apr_brigade_write et
+     * al may place transient buckets in the brigade, which will fall
+     * out of scope after returning.  Empty the brigade here, to avoid
+     * issues with leaving such buckets in the brigade if some filter
+     * fails and leaves a non-empty brigade. */
     apr_brigade_cleanup(bb);
 
     return rv;