From: Justin Bedő Date: Tue, 25 Jul 2017 17:30:20 +0000 (+1000) Subject: Fix autoconf detection of super_setup_bdi_name X-Git-Tag: zfs-0.7.0~6 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f269060a24d1f43a30d647e0835ca4fcaac6bae9;p=zfs Fix autoconf detection of super_setup_bdi_name The previous autoconf test for the presence of super_setup_bdi_name() uses an invocation with an incorrect type signature, producing a warning by the compiler when the test is run. This gets elevated to an error when compiling with -Werror=format-security, causing autoconf to falsely infer super_setup_bdi_name() is not present. This updates the testing code to match the invocation used in include/linux/vfs_compat.h. Reviewed-by: loli10K Reviewed-by: Brian Behlendorf Signed-off-by: Justin Bedo Closes #6398 --- diff --git a/config/kernel-bdi.m4 b/config/kernel-bdi.m4 index c2a9dd28b..cb7479ee9 100644 --- a/config/kernel-bdi.m4 +++ b/config/kernel-bdi.m4 @@ -11,8 +11,9 @@ AC_DEFUN([ZFS_AC_KERNEL_BDI], [ struct super_block sb; ], [ char *name = "bdi"; + atomic_long_t zfs_bdi_seq; int error __attribute__((unused)) = - super_setup_bdi_name(&sb, name); + super_setup_bdi_name(&sb, "%.28s-%ld", name, atomic_long_inc_return(&zfs_bdi_seq)); ], [super_setup_bdi_name], [fs/super.c], [ AC_MSG_RESULT(yes) AC_DEFINE(HAVE_SUPER_SETUP_BDI_NAME, 1,