From: James Zern <jzern@google.com>
Date: Mon, 5 Nov 2012 20:50:16 +0000 (-0800)
Subject: rdopt: fix use of uninitialized value in addition
X-Git-Tag: v1.3.0~1217^2~118^2~7
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f2541f8a4a1a6503c43de0ea8954f4b7ea2d2499;p=libvpx

rdopt: fix use of uninitialized value in addition

rd_pick_intra4x4mby_modes / rd_pick_intra8x8mby_modes would both use the
input value of 'rate_y' in the return calculation. In many places this
value is uninitialized. Remove the unneeded sum.

Change-Id: Icbd3df685303000301e69291c0ebc06f74bd548d
---

diff --git a/vp9/encoder/rdopt.c b/vp9/encoder/rdopt.c
index 71b8a2ea7..ffff248ac 100644
--- a/vp9/encoder/rdopt.c
+++ b/vp9/encoder/rdopt.c
@@ -1180,7 +1180,7 @@ static int64_t rd_pick_intra4x4mby_modes(VP9_COMP *cpi, MACROBLOCK *mb, int *Rat
   cost += vp9_cost_bit(128, allow_comp);
 #endif
   *Rate = cost;
-  *rate_y += tot_rate_y;
+  *rate_y = tot_rate_y;
   *Distortion = distortion;
 
   return RDCOST(mb->rdmult, mb->rddiv, cost, distortion);
@@ -1516,7 +1516,7 @@ static int64_t rd_pick_intra8x8mby_modes(VP9_COMP *cpi, MACROBLOCK *mb,
 #endif
   }
   *Rate = cost;
-  *rate_y += tot_rate_y;
+  *rate_y = tot_rate_y;
   *Distortion = distortion;
   return RDCOST(mb->rdmult, mb->rddiv, cost, distortion);
 }