From: Chris Lattner <sabre@nondot.org>
Date: Mon, 10 Nov 2008 06:10:01 +0000 (+0000)
Subject: Fix even more bugs in debug info support:
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f2528e045c12dd743a83b5141eba36d6aa947cbb;p=clang

Fix even more bugs in debug info support:
1. emit proper debug info for forward decls of structs.
2. emit DW_TAG_member nodes around members of a field like llvm-gcc does.

This slows down debug info generation, but is required for correctness.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@58973 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/CodeGen/CGDebugInfo.cpp b/lib/CodeGen/CGDebugInfo.cpp
index 4b3ef0ebd0..42139353eb 100644
--- a/lib/CodeGen/CGDebugInfo.cpp
+++ b/lib/CodeGen/CGDebugInfo.cpp
@@ -192,9 +192,6 @@ llvm::DIType CGDebugInfo::CreateType(const RecordType *Ty,
                                      llvm::DICompileUnit Unit) {
   const RecordDecl *Decl = Ty->getDecl();
   
-  if (!Decl->getDefinition(M->getContext()))
-    return llvm::DIType();
-  
   unsigned Tag;
   if (Decl->isStruct())
     Tag = llvm::dwarf::DW_TAG_structure_type;
@@ -244,7 +241,6 @@ llvm::DIType CGDebugInfo::CreateType(const RecordType *Ty,
     FieldDecl *Field = *I;
     llvm::DIType FieldTy = getOrCreateType(Field->getType(), Unit);
     
-#if 0
     const char *FieldName = Field->getName();
     if (FieldName == 0) FieldName = "";
 
@@ -265,7 +261,6 @@ llvm::DIType CGDebugInfo::CreateType(const RecordType *Ty,
                                              FieldName, FieldDefUnit,
                                              FieldLine, FieldSize, FieldAlign,
                                              FieldOffset, 0, FieldTy);
-#endif
     EltTys.push_back(FieldTy);
   }