From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Fri, 8 Sep 2017 21:37:43 +0000 (-0400)
Subject: Fix more portability issues in new pgbench TAP tests.
X-Git-Tag: REL_11_BETA1~1640
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f25000c832f2e147986110116d4ba1a57b9d9256;p=postgresql

Fix more portability issues in new pgbench TAP tests.

Not completely sure, but I think bowerbird is spitting up on attempting
to include ">" in a temporary file name.  (Why in the world are we
writing this stuff into files at all?  A hash would be a better answer.)
---

diff --git a/src/bin/pgbench/t/001_pgbench_with_server.pl b/src/bin/pgbench/t/001_pgbench_with_server.pl
index b80640a8cc..3609b9bede 100644
--- a/src/bin/pgbench/t/001_pgbench_with_server.pl
+++ b/src/bin/pgbench/t/001_pgbench_with_server.pl
@@ -132,7 +132,7 @@ my $nthreads = 2;
 {
 	my ($stderr);
 	run_log([ 'pgbench', '-j', '2', '--bad-option' ], '2>', \$stderr);
-	$nthreads = 1 if $stderr =~ 'threads are not supported on this platform';
+	$nthreads = 1 if $stderr =~ m/threads are not supported on this platform/;
 }
 
 # run custom scripts
@@ -354,7 +354,7 @@ SELECT LEAST(:i, :i, :i, :i, :i, :i, :i, :i, :i, :i, :i);
 		0,
 		[qr{gaussian param.* at least 2}],
 		q{\set i random_gaussian(0, 10, 1.0)} ],
-	[   'set exponential param > 0',
+	[   'set exponential param greater 0',
 		0,
 		[qr{exponential parameter must be greater }],
 		q{\set i random_exponential(0, 10, 0.0)} ],