From: Andres Freund <andres@anarazel.de>
Date: Wed, 6 Mar 2019 17:54:38 +0000 (-0800)
Subject: Fix bug in clearing of virtual tuple slot.
X-Git-Tag: REL_12_BETA1~613
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f21776185648537a7bb82dfdf89991fb2e0b9ca5;p=postgresql

Fix bug in clearing of virtual tuple slot.

I broke/typoed this in 4da597edf1bae0c. Astonishingly this mostly
doesn't cause breakage, except when trying to change the tuple
descriptor of a slot (because TTS_FLAG_FIXED is assumed to be set).

Author: Andres Freund
---

diff --git a/src/backend/executor/execTuples.c b/src/backend/executor/execTuples.c
index 2a12bd56ea..41fa374b6f 100644
--- a/src/backend/executor/execTuples.c
+++ b/src/backend/executor/execTuples.c
@@ -114,7 +114,7 @@ tts_virtual_clear(TupleTableSlot *slot)
 		pfree(vslot->data);
 		vslot->data = NULL;
 
-		slot->tts_flags = ~TTS_FLAG_SHOULDFREE;
+		slot->tts_flags &= ~TTS_FLAG_SHOULDFREE;
 	}
 
 	slot->tts_nvalid = 0;