From: Pieter Lexis <pieter.lexis@powerdns.com>
Date: Thu, 24 Mar 2016 08:17:28 +0000 (+0100)
Subject: Lowercase names when inserting in the database
X-Git-Tag: dnsdist-1.0.0-beta1~65^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f1c083f24d1723c9771fe832525097eee736c67d;p=pdns

Lowercase names when inserting in the database

Closes #3583
---

diff --git a/pdns/backends/gsql/gsqlbackend.cc b/pdns/backends/gsql/gsqlbackend.cc
index c607b1711..bcba0baef 100644
--- a/pdns/backends/gsql/gsqlbackend.cc
+++ b/pdns/backends/gsql/gsqlbackend.cc
@@ -1305,7 +1305,7 @@ bool GSQLBackend::feedRecord(const DNSResourceRecord &r, string *ordername)
       bind("qtype",r.qtype.getName())->
       bind("domain_id",r.domain_id)->
       bind("disabled",r.disabled)->
-      bind("qname",stripDot(r.qname.toString())); // FIXME400 lowercase?
+      bind("qname",r.qname);
 
     if (ordername == NULL)
       d_InsertRecordQuery_stmt->bindNull("ordername");
diff --git a/pdns/backends/gsql/ssql.hh b/pdns/backends/gsql/ssql.hh
index 293b2dce2..3b43b2471 100644
--- a/pdns/backends/gsql/ssql.hh
+++ b/pdns/backends/gsql/ssql.hh
@@ -47,7 +47,7 @@ public:
   virtual SSqlStatement* bind(const string& name, unsigned long long value)=0;
   virtual SSqlStatement* bind(const string& name, const std::string& value)=0;
   SSqlStatement* bind(const string& name, const DNSName& value) {
-    return bind(name, toLower(value.toStringNoDot())); // FIXME400 toLower()?
+    return bind(name, toLower(value.toStringNoDot()));
   }
   virtual SSqlStatement* bindNull(const string& name)=0;
   virtual SSqlStatement* execute()=0;;