From: Ted Kremenek Date: Fri, 14 Aug 2009 20:51:58 +0000 (+0000) Subject: Use 'dyn_cast' instead of a check for a function declaration followed by a X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f1858598d2dea36991df88bb32a795797ea1c316;p=clang Use 'dyn_cast' instead of a check for a function declaration followed by a 'cast'. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@79041 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Sema/SemaDeclAttr.cpp b/lib/Sema/SemaDeclAttr.cpp index 4952e62900..e65b3aa6fd 100644 --- a/lib/Sema/SemaDeclAttr.cpp +++ b/lib/Sema/SemaDeclAttr.cpp @@ -438,13 +438,14 @@ static void HandleMallocAttr(Decl *d, const AttributeList &Attr, Sema &S) { return; } - if (!isFunction(d)) { + const FunctionDecl *FD = dyn_cast(d); + + if (!FD) { S.Diag(Attr.getLoc(), diag::warn_attribute_wrong_decl_type) << Attr.getName() << 0 /*function*/; return; } - const FunctionDecl *FD = cast(d); QualType RetTy = FD->getResultType(); if (!(RetTy->isAnyPointerType() || RetTy->isBlockPointerType())) {