From: Alvaro Herrera Date: Fri, 1 Sep 2017 14:30:02 +0000 (+0200) Subject: Restore behavior for replication origin drop X-Git-Tag: REL_10_RC1~50 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f15b76a9010dfd6052405d058bf8c0a488cec979;p=postgresql Restore behavior for replication origin drop Do for replication origins what the previous commit did for replication slots: restore the original behavior of replication origin drop to raise an error rather than blocking, because users might be depending on the original behavior. Maintain the blocking behavior when invoked internally from logical replication subscription handling. Discussion: https://postgr.es/m/20170830133922.tlpo3lgfejm4n2cs@alvherre.pgsql --- diff --git a/src/backend/replication/logical/origin.c b/src/backend/replication/logical/origin.c index 14cb3d0bf2..edc6efb8a6 100644 --- a/src/backend/replication/logical/origin.c +++ b/src/backend/replication/logical/origin.c @@ -1205,7 +1205,7 @@ pg_replication_origin_drop(PG_FUNCTION_ARGS) roident = replorigin_by_name(name, false); Assert(OidIsValid(roident)); - replorigin_drop(roident, false); + replorigin_drop(roident, true); pfree(name);