From: Michael Paquier Date: Wed, 20 Feb 2019 03:31:45 +0000 (+0900) Subject: Mark correctly initial slot snapshots with MVCC type when built X-Git-Tag: REL9_6_13~69 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f131889519ad3243739b430df70c379652a79156;p=postgresql Mark correctly initial slot snapshots with MVCC type when built When building an initial slot snapshot, snapshots are marked with historic MVCC snapshots as type with the marker field being set in SnapBuildBuildSnapshot() but not overriden in SnapBuildExportSnapshot(). Existing callers of SnapBuildBuildSnapshot() do not care about the type of snapshot used, but extensions calling it actually may, as reported. Author: Antonin Houska Reviewed-by: Álvaro Herrera, Michael Paquier Discussion: https://postgr.es/m/23215.1527665193@localhost Backpatch-through: 9.4 --- diff --git a/src/backend/replication/logical/snapbuild.c b/src/backend/replication/logical/snapbuild.c index 546e0e7b16..cdc117763c 100644 --- a/src/backend/replication/logical/snapbuild.c +++ b/src/backend/replication/logical/snapbuild.c @@ -633,6 +633,8 @@ SnapBuildExportSnapshot(SnapBuild *builder) TransactionIdAdvance(xid); } + /* adjust remaining snapshot fields as needed */ + snap->satisfies = HeapTupleSatisfiesMVCC; snap->xcnt = newxcnt; snap->xip = newxip;