From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Wed, 23 Apr 2003 18:19:23 +0000 (+0000)
Subject: Fix misbehavior of replace() on strings containing '%'.
X-Git-Tag: REL7_3_3~26
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f094673357cb2ef966c122ec31eee7ce544d2f6e;p=postgresql

Fix misbehavior of replace() on strings containing '%'.
Will patch separately but equivalently in HEAD.
---

diff --git a/src/backend/utils/adt/varlena.c b/src/backend/utils/adt/varlena.c
index e21e59e1be..e0bf6b6857 100644
--- a/src/backend/utils/adt/varlena.c
+++ b/src/backend/utils/adt/varlena.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/utils/adt/varlena.c,v 1.92 2002/09/04 20:31:29 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/utils/adt/varlena.c,v 1.92.2.1 2003/04/23 18:19:23 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1684,8 +1684,8 @@ replace_text(PG_FUNCTION_ARGS)
 		left_text = LEFT(buf_text, from_sub_text);
 		right_text = RIGHT(buf_text, from_sub_text, from_sub_text_len);
 
-		appendStringInfo(str, PG_TEXT_GET_STR(left_text));
-		appendStringInfo(str, to_sub_str);
+		appendStringInfo(str, "%s", PG_TEXT_GET_STR(left_text));
+		appendStringInfo(str, "%s", to_sub_str);
 
 		pfree(buf_text);
 		pfree(left_text);
@@ -1693,7 +1693,7 @@ replace_text(PG_FUNCTION_ARGS)
 		curr_posn = TEXTPOS(buf_text, from_sub_text);
 	}
 
-	appendStringInfo(str, PG_TEXT_GET_STR(buf_text));
+	appendStringInfo(str, "%s", PG_TEXT_GET_STR(buf_text));
 	pfree(buf_text);
 
 	ret_text = PG_STR_GET_TEXT(str->data);