From: Bram Moolenaar Date: Tue, 2 Aug 2022 10:48:53 +0000 (+0100) Subject: patch 9.0.0134: no test for text property with column zero X-Git-Tag: v9.0.0134 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f05a1e59a3df759667f2082cf42368945c57e389;p=vim patch 9.0.0134: no test for text property with column zero Problem: No test for text property with column zero. Solution: Add a test. Add message to assert for no open popups. --- diff --git a/src/testdir/runtest.vim b/src/testdir/runtest.vim index 69443c5f9..c7140e530 100644 --- a/src/testdir/runtest.vim +++ b/src/testdir/runtest.vim @@ -245,7 +245,7 @@ func RunTheTest(test) " Check for and close any stray popup windows. if has('popupwin') - call assert_equal([], popup_list()) + call assert_equal([], popup_list(), 'Popup is still present') call popup_clear(1) endif diff --git a/src/testdir/test_textprop.vim b/src/testdir/test_textprop.vim index c05a96389..216ae20a4 100644 --- a/src/testdir/test_textprop.vim +++ b/src/testdir/test_textprop.vim @@ -1611,6 +1611,23 @@ func Test_prop_one_line_window() bwipe! endfunc +def Test_prop_column_zero_error() + prop_type_add('proptype', {highlight: 'Search'}) + var caught = false + try + popup_create([{ + text: 'a', + props: [{col: 0, length: 1, type: 'type'}], + }], {}) + catch /E964:/ + caught = true + endtry + assert_true(caught) + + popup_clear() + prop_type_delete('proptype') +enddef + " This was calling ml_append_int() and copy a text property from a previous " line at the wrong moment. Exact text length matters. def Test_prop_splits_data_block() diff --git a/src/version.c b/src/version.c index 75f24c66e..6113e333f 100644 --- a/src/version.c +++ b/src/version.c @@ -735,6 +735,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ +/**/ + 134, /**/ 133, /**/