From: Ezio Melotti <ezio.melotti@gmail.com>
Date: Fri, 29 Mar 2013 23:32:45 +0000 (+0200)
Subject: #17564: skip test_bad_address unless the tests are run with -unetwork/-uall.
X-Git-Tag: v2.7.5~128
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f03aab7e519b2c801b193907086f064867ef53c1;p=python

#17564: skip test_bad_address unless the tests are run with -unetwork/-uall.
---

diff --git a/Lib/test/test_urllib2_localnet.py b/Lib/test/test_urllib2_localnet.py
index ec3437597d..0802f69dc8 100644
--- a/Lib/test/test_urllib2_localnet.py
+++ b/Lib/test/test_urllib2_localnet.py
@@ -489,6 +489,11 @@ class TestUrlopen(BaseTestCase):
     def test_bad_address(self):
         # Make sure proper exception is raised when connecting to a bogus
         # address.
+
+        # as indicated by the comment below, this might fail with some ISP,
+        # so we run the test only when -unetwork/-uall is specified to
+        # mitigate the problem a bit (see #17564)
+        test_support.requires('network')
         self.assertRaises(IOError,
                           # Given that both VeriSign and various ISPs have in
                           # the past or are presently hijacking various invalid