From: Xinchen Hui <laruence@php.net>
Date: Wed, 22 Oct 2014 09:25:41 +0000 (+0800)
Subject: Better convert
X-Git-Tag: POST_NATIVE_TLS_MERGE^2~49^2~39^2~30
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f03100cb8098baf57e3e2b81664fd90914c773dc;p=php

Better convert
---

diff --git a/ext/standard/string.c b/ext/standard/string.c
index 706a3eb075..e757821813 100644
--- a/ext/standard/string.c
+++ b/ext/standard/string.c
@@ -1663,12 +1663,10 @@ static int php_needle_char(zval *needle, char *target TSRMLS_DC)
 			return SUCCESS;
 		case IS_OBJECT:
 			{
-				zval holder = *needle;
-				zval_copy_ctor(&(holder));
-				convert_to_long(&(holder));
-				if(Z_TYPE(holder) != IS_LONG) {
-					return FAILURE;
-				}
+				zval holder;
+			   
+				ZVAL_LONG(&holder, zval_get_long(needle));
+
 				*target = (char)Z_LVAL(holder);
 				return SUCCESS;
 			}