From: INADA Naoki <methane@users.noreply.github.com>
Date: Tue, 28 Mar 2017 15:25:26 +0000 (+0900)
Subject: bpo-29643: Fix check for --enable-optimizations (GH-869)
X-Git-Tag: v3.6.2rc1~276
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=f01de61a8efea8319c65365898982f929d59a895;p=python

bpo-29643: Fix check for --enable-optimizations (GH-869)

The presence of the ``--enable-optimizations`` flag is indicated by the
value of ``$enableval``, but the configure script was checking ``$withval``,
resulting in the ``--enable-optimizations`` flag being effectively ignored.
(cherry picked from commit 8cea5929f52801b0ce5928b46ef836e99a24321a)
---

diff --git a/Misc/NEWS b/Misc/NEWS
index 9798a3a449..45c5c78287 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -60,6 +60,11 @@ Library
   exception) to exception(s) raised in the dispatched methods.
   Patch by Petr Motejlek.
 
+Build
+-----
+
+- bpo-29643: Fix ``--enable-optimization`` didn't work.
+
 
 What's New in Python 3.6.1?
 ===========================
diff --git a/configure b/configure
index abe1dc5abd..8bdb82ba4a 100755
--- a/configure
+++ b/configure
@@ -6521,7 +6521,7 @@ $as_echo_n "checking for --enable-optimizations... " >&6; }
 # Check whether --enable-optimizations was given.
 if test "${enable_optimizations+set}" = set; then :
   enableval=$enable_optimizations;
-if test "$withval" != no
+if test "$enableval" != no
 then
   Py_OPT='true'
   { $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5
diff --git a/configure.ac b/configure.ac
index 9eacf52559..6b331d5742 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1274,7 +1274,7 @@ Py_OPT='false'
 AC_MSG_CHECKING(for --enable-optimizations)
 AC_ARG_ENABLE(optimizations, AS_HELP_STRING([--enable-optimizations], [Enable expensive optimizations (PGO, etc).  Disabled by default.]),
 [
-if test "$withval" != no
+if test "$enableval" != no
 then
   Py_OPT='true'
   AC_MSG_RESULT(yes);