From: Simon Riggs <simon@2ndQuadrant.com>
Date: Tue, 7 Aug 2012 15:21:49 +0000 (+0100)
Subject: fsync backup_label after pg_start_backup()
X-Git-Tag: REL9_1_5~9
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=efed8c0031dbae0adb4ed4cb6197acd57397d2e9;p=postgresql

fsync backup_label after pg_start_backup()

Dave Kerr, backpatched by Simon Riggs
---

diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index 1612f44e4e..adf5bc93de 100644
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -9093,7 +9093,8 @@ do_pg_start_backup(const char *backupidstr, bool fast, char **labelfile)
 						 errmsg("could not create file \"%s\": %m",
 								BACKUP_LABEL_FILE)));
 			fwrite(labelfbuf.data, labelfbuf.len, 1, fp);
-			if (fflush(fp) || ferror(fp) || FreeFile(fp))
+
+			if (fflush(fp) || ferror(fp) || pg_fsync(fileno(fp)) != 0 || FreeFile(fp))
 				ereport(ERROR,
 						(errcode_for_file_access(),
 						 errmsg("could not write file \"%s\": %m",