From: Brian Behlendorf <behlendorf1@llnl.gov>
Date: Sat, 30 Jul 2016 00:10:11 +0000 (-0700)
Subject: Fix gcc self-comparison warning
X-Git-Tag: zfs-0.7.0-rc1~56
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=efe7978d89f84f08afd9a3bf84a293773b66632d;p=zfs

Fix gcc self-comparison warning

As of gcc 6.1.1 20160621 (Red Hat 6.1.1-3) a self-comparison is
detected by gcc in metaslab_alloc().  Resolve the warning by passing
a physical size of 0 to BP_SET_BIRTH() as it done by other callers.

  module/zfs/metaslab.c: In function ‘metaslab_alloc’:
  module/zfs/metaslab.c:2575:184: error: self-comparison always evaluates
      to true [-Werror=tautological-compare]

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Gvozden Neskovic <neskovic@gmail.com>
Issue #4907
---

diff --git a/module/zfs/metaslab.c b/module/zfs/metaslab.c
index c2c1d2dfc..a4cf39a3f 100644
--- a/module/zfs/metaslab.c
+++ b/module/zfs/metaslab.c
@@ -2572,7 +2572,7 @@ metaslab_alloc(spa_t *spa, metaslab_class_t *mc, uint64_t psize, blkptr_t *bp,
 
 	spa_config_exit(spa, SCL_ALLOC, FTAG);
 
-	BP_SET_BIRTH(bp, txg, txg);
+	BP_SET_BIRTH(bp, txg, 0);
 
 	return (0);
 }