From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Sun, 2 Jul 2017 21:22:09 +0000 (-0400)
Subject: Fix bug in PostgresNode::query_hash's split() call.
X-Git-Tag: REL_10_BETA2~31
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=efdb4f29ba9ecbddb74d3a68577f068cf034c540;p=postgresql

Fix bug in PostgresNode::query_hash's split() call.

By default, Perl's split() function drops trailing empty fields,
which is not what we want here.  Oversight in commit fb093e4cb.
We'd managed to miss it thus far thanks to the very limited usage
of this function.

Discussion: https://postgr.es/m/14837.1499029831@sss.pgh.pa.us
---

diff --git a/src/test/perl/PostgresNode.pm b/src/test/perl/PostgresNode.pm
index 4346423a0d..bb2f39e508 100644
--- a/src/test/perl/PostgresNode.pm
+++ b/src/test/perl/PostgresNode.pm
@@ -1533,7 +1533,7 @@ sub query_hash
 	#
 	my %val;
 	@val{@columns} =
-	  $result ne '' ? split(qr/\|/, $result) : ('',) x scalar(@columns);
+	  $result ne '' ? split(qr/\|/, $result, -1) : ('',) x scalar(@columns);
 	return \%val;
 }