From: Ulf Wendel <uw@php.net>
Date: Tue, 20 Oct 2009 14:11:43 +0000 (+0000)
Subject: libmysql is still 'buggy' - skip test with libmysql
X-Git-Tag: php-5.4.0alpha1~191^2~2482
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ef738f83144fdff31d6d838799ca9ab14adce421;p=php

libmysql is still 'buggy' - skip test with libmysql
---

diff --git a/ext/mysqli/tests/mysqli_change_user_insert_id.phpt b/ext/mysqli/tests/mysqli_change_user_insert_id.phpt
index 83efb51492..30ea541474 100644
--- a/ext/mysqli/tests/mysqli_change_user_insert_id.phpt
+++ b/ext/mysqli/tests/mysqli_change_user_insert_id.phpt
@@ -6,13 +6,16 @@ require_once('skipif.inc');
 require_once('skipifemb.inc');
 require_once('skipifconnectfailure.inc');
 require_once('connect.inc');
+
 if (!$IS_MYSQLND) {
 	if (!$link = my_mysqli_connect($host, $user, $passwd, $db, $port, $socket))
 		die("skip Can't test server version, might hit known bugs http://bugs.mysql.com/bug.php?id=30472, http://bugs.mysql.com/bug.php?id=45184");
-	if (mysqli_get_client_version($link) <= 50135)
-		/* TODO - check wich version got the patch */
+
+	if ((mysqli_get_client_version($link) <= 50139) || (mysqli_get_server_version($link) <= 50139))
+		/* #30472 got fixed in 5.1.23 but #45184 is open */
 		die(sprintf("skip libmysql %s should have bugs http://bugs.mysql.com/bug.php?id=30472, http://bugs.mysql.com/bug.php?id=45184",
 	 mysqli_get_client_version($link)));
+
 	mysqli_close($link);
 }
 ?>