From: Andrey Hristov <andrey@php.net>
Date: Fri, 25 Sep 2009 12:35:58 +0000 (+0000)
Subject: Fix returned value, if mysql_stmt_attr_set fails
X-Git-Tag: php-5.2.12RC1~105
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ef17ae4ecb55f18429ff502115ee1c9f6520722a;p=php

Fix returned value, if mysql_stmt_attr_set fails
then mysqli returns true, otherwise false. Wrong logic.
---

diff --git a/ext/mysqli/mysqli_api.c b/ext/mysqli/mysqli_api.c
index 039a771f91..2c4e6b9c29 100644
--- a/ext/mysqli/mysqli_api.c
+++ b/ext/mysqli/mysqli_api.c
@@ -1848,14 +1848,13 @@ PHP_FUNCTION(mysqli_stmt_attr_set)
 	zval 	*mysql_stmt;
 	ulong   mode;
 	ulong	attr;
-	int		rc;
 
 	if (zend_parse_method_parameters(ZEND_NUM_ARGS() TSRMLS_CC, getThis(), "Oll", &mysql_stmt, mysqli_stmt_class_entry, &attr, &mode) == FAILURE) {
 		return;
 	}
 	MYSQLI_FETCH_RESOURCE(stmt, MY_STMT *, &mysql_stmt, "mysqli_stmt", MYSQLI_STATUS_VALID);
 
-	if ((rc = mysql_stmt_attr_set(stmt->stmt, attr, (void *)&mode))) {
+	if (FALSE == mysql_stmt_attr_set(stmt->stmt, attr, (void *)&mode)) {
 		RETURN_FALSE;
 	}
 	RETURN_TRUE;