From: Paul Ramsey <pramsey@cleverelephant.ca>
Date: Wed, 28 Oct 2009 23:05:09 +0000 (+0000)
Subject: Note why the penalty function was changed.
X-Git-Tag: 1.5.0b1~332
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ee973cfc1465a44119bf69b20bb677b76b3dd238;p=postgis

Note why the penalty function was changed.


git-svn-id: http://svn.osgeo.org/postgis/trunk@4694 b70326c6-7e19-0410-871a-916f4a2858ee
---

diff --git a/postgis/geography_gist.c b/postgis/geography_gist.c
index f0ed8c320..5eec1ad47 100644
--- a/postgis/geography_gist.c
+++ b/postgis/geography_gist.c
@@ -868,6 +868,9 @@ Datum geography_gist_penalty(PG_FUNCTION_ARGS)
 	*result = size_union - size_orig;
 
 	/* All things being equal, we prefer to expand small boxes rather than large boxes. 
+	   NOTE: This code seemed to be causing badly balanced trees to be built
+	   and therefore has been commented out. Not sure why it didn't work,
+	   but it didn't.
 	if( FP_IS_ZERO(*result) )
 		if( FP_IS_ZERO(size_orig) )
 			*result = 0.0;