From: Vinay Sajip <vinay_sajip@yahoo.co.uk>
Date: Tue, 16 Oct 2012 09:28:31 +0000 (+0100)
Subject: Issue #16244: Remove file mode overrides.
X-Git-Tag: v3.3.1rc1~799^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ee892b9226be97a159823866463fb39474f55835;p=python

Issue #16244: Remove file mode overrides.
---

diff --git a/Lib/logging/handlers.py b/Lib/logging/handlers.py
index 2e29f92b70..8349d3a7fb 100644
--- a/Lib/logging/handlers.py
+++ b/Lib/logging/handlers.py
@@ -137,7 +137,6 @@ class RotatingFileHandler(BaseRotatingHandler):
             if os.path.exists(dfn):
                 os.remove(dfn)
             os.rename(self.baseFilename, dfn)
-        self.mode = 'w'
         self.stream = self._open()
 
     def shouldRollover(self, record):
@@ -345,7 +344,6 @@ class TimedRotatingFileHandler(BaseRotatingHandler):
         if self.backupCount > 0:
             for s in self.getFilesToDelete():
                 os.remove(s)
-        self.mode = 'w'
         self.stream = self._open()
         newRolloverAt = self.computeRollover(currentTime)
         while newRolloverAt <= currentTime: