From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Fri, 15 Apr 2016 04:02:26 +0000 (-0400)
Subject: Fix memory leak in GIN index scans.
X-Git-Tag: REL9_5_3~39
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=edd57377f0db00a66d39029aa5239a96280887ef;p=postgresql

Fix memory leak in GIN index scans.

The code had a query-lifespan memory leak when encountering GIN entries
that have posting lists (rather than posting trees, ie, there are a
relatively small number of heap tuples containing this index key value).
With a suitable data distribution this could add up to a lot of leakage.
Problem seems to have been introduced by commit 36a35c550, so back-patch
to 9.4.

Julien Rouhaud
---

diff --git a/src/backend/access/gin/ginget.c b/src/backend/access/gin/ginget.c
index ee2eb63346..dcca7f4268 100644
--- a/src/backend/access/gin/ginget.c
+++ b/src/backend/access/gin/ginget.c
@@ -278,6 +278,7 @@ collectMatchBitmap(GinBtreeData *btree, GinBtreeStack *stack,
 			ipd = ginReadTuple(btree->ginstate, scanEntry->attnum, itup, &nipd);
 			tbm_add_tuples(scanEntry->matchBitmap, ipd, nipd, false);
 			scanEntry->predictNumberResult += GinGetNPosting(itup);
+			pfree(ipd);
 		}
 
 		/*