From: Daniel Stutzbach <daniel.stutzbach@google.com>
Date: Wed, 4 May 2011 19:46:28 +0000 (-0700)
Subject: #11335: Fix memory leak after key function failure in sort
X-Git-Tag: v3.2.1b1~23
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=eda70b81d3346f1831efe0f1b9553ef9f1bb4ca3;p=python

#11335: Fix memory leak after key function failure in sort
---

diff --git a/Lib/test/test_sort.py b/Lib/test/test_sort.py
index a7afe73d1c..55503b57a8 100644
--- a/Lib/test/test_sort.py
+++ b/Lib/test/test_sort.py
@@ -111,6 +111,12 @@ class TestBase(unittest.TestCase):
             s.sort(key=CmpToKey(lambda a, b:  int(random.random() * 3) - 1))
             check("an insane function left some permutation", x, s)
 
+            if len(x) >= 2:
+                def bad_key(x):
+                    raise RuntimeError
+                s = x[:]
+                self.assertRaises(RuntimeError, s.sort, key=bad_key)
+
             x = [Complains(i) for i in x]
             s = x[:]
             random.shuffle(s)
diff --git a/Objects/listobject.c b/Objects/listobject.c
index 18713abde1..73624f0b74 100644
--- a/Objects/listobject.c
+++ b/Objects/listobject.c
@@ -1944,6 +1944,8 @@ listsort(PyListObject *self, PyObject *args, PyObject *kwds)
             if (keys[i] == NULL) {
                 for (i=i-1 ; i>=0 ; i--)
                     Py_DECREF(keys[i]);
+                if (keys != &ms.temparray[saved_ob_size+1])
+                    PyMem_FREE(keys);
                 goto keyfunc_fail;
             }
         }