From: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Date: Wed, 31 Aug 2011 10:32:55 +0000 (+0200)
Subject: Dumping error triggered removing references twice and lead to kernel BUG
X-Git-Tag: v6.9~9
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ed9c6570aa746bdfc4e006e3fdd25b69f04cd6a2;p=ipset

Dumping error triggered removing references twice and lead to kernel BUG

If there was a dumping error in the middle, the set-specific variable was
not zeroed out and thus the 'done' function of the dumping wrongly tried
to release the already released reference of the set. The already released
reference was caught by __ip_set_put and triggered a kernel BUG message.
The issue was reported by Jean-Philippe Menil.
---

diff --git a/kernel/net/netfilter/ipset/ip_set_core.c b/kernel/net/netfilter/ipset/ip_set_core.c
index b5d380c..c3eabfd 100644
--- a/kernel/net/netfilter/ipset/ip_set_core.c
+++ b/kernel/net/netfilter/ipset/ip_set_core.c
@@ -1148,6 +1148,7 @@ release_refcount:
 	if (ret || !cb->args[2]) {
 		pr_debug("release set %s\n", ip_set_list[index]->name);
 		ip_set_put_byindex(index);
+		cb->args[2] = 0;
 	}
 out:
 	if (nlh) {