From: Martin v. Löwis <martin@v.loewis.de>
Date: Sun, 3 Jun 2001 14:06:42 +0000 (+0000)
Subject: Fix getElementsByTagNameNS:
X-Git-Tag: v2.2a3~1624
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ed525fb0dfa45595e8e93cbde3d5b05838bf993a;p=python

Fix getElementsByTagNameNS:
  - actually return a result
  - Compare with tag.localName in getElementsByTagNameNSHelper
---

diff --git a/Lib/xml/dom/minidom.py b/Lib/xml/dom/minidom.py
index 97d622f36f..59f86a75e7 100644
--- a/Lib/xml/dom/minidom.py
+++ b/Lib/xml/dom/minidom.py
@@ -279,7 +279,7 @@ def _getElementsByTagNameHelper(parent, name, rc):
 def _getElementsByTagNameNSHelper(parent, nsURI, localName, rc):
     for node in parent.childNodes:
         if node.nodeType == Node.ELEMENT_NODE:
-            if ((localName == "*" or node.tagName == localName) and
+            if ((localName == "*" or node.localName == localName) and
                 (nsURI == "*" or node.namespaceURI == nsURI)):
                 rc.append(node)
             _getElementsByTagNameNSHelper(node, nsURI, localName, rc)
@@ -551,7 +551,9 @@ class Element(Node):
         return _getElementsByTagNameHelper(self, name, [])
 
     def getElementsByTagNameNS(self, namespaceURI, localName):
-        _getElementsByTagNameNSHelper(self, namespaceURI, localName, [])
+        rc = []
+        _getElementsByTagNameNSHelper(self, namespaceURI, localName, rc)
+        return rc
 
     def __repr__(self):
         return "<DOM Element: %s at %s>" % (self.tagName, id(self))
@@ -880,7 +882,9 @@ class Document(Node):
         return a
 
     def getElementsByTagNameNS(self, namespaceURI, localName):
-        _getElementsByTagNameNSHelper(self, namespaceURI, localName)
+        rc = []
+        _getElementsByTagNameNSHelper(self, namespaceURI, localName, rc)
+        return rc
 
     def getElementsByTagName(self, name):
         rc = []