From: Jeffrey Yasskin <jyasskin@gmail.com>
Date: Tue, 18 Mar 2008 05:12:41 +0000 (+0000)
Subject: Speed up test_dict by about 10x by only checking selected dict literal sizes,
X-Git-Tag: v2.6a2~281
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ed414654c480b440679062c873953ab05a31c897;p=python

Speed up test_dict by about 10x by only checking selected dict literal sizes,
instead of every integer from 0 to 400. Exhaustive testing wastes time without
providing enough more assurance that the code is correct.
---

diff --git a/Lib/test/test_dict.py b/Lib/test/test_dict.py
index 7dd5f06868..b62237d9d6 100644
--- a/Lib/test/test_dict.py
+++ b/Lib/test/test_dict.py
@@ -12,12 +12,14 @@ class DictTest(unittest.TestCase):
 
     def test_literal_constructor(self):
         # check literal constructor for different sized dicts (to exercise the BUILD_MAP oparg
-        items = []
-        for n in range(400):
+        for n in (0, 1, 6, 256, 400):
+            items = [(''.join([random.choice(string.letters)
+                               for j in range(8)]),
+                      i)
+                     for i in range(n)]
+            random.shuffle(items)
             dictliteral = '{' + ', '.join('%r: %d' % item for item in items) + '}'
             self.assertEqual(eval(dictliteral), dict(items))
-            items.append((''.join([random.choice(string.letters) for j in range(8)]), n))
-            random.shuffle(items)
 
     def test_bool(self):
         self.assert_(not {})