From: Senthil Kumaran <skumaran@gatech.edu>
Date: Fri, 31 Mar 2017 05:43:05 +0000 (-0700)
Subject: Remove catching OSError in ftphandler test. Only URLError is raised in urllib.request... 
X-Git-Tag: v3.7.0a1~1031
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ed3dd1c02af6872bd0748f7b9a5dadb89f7b830f;p=python

Remove catching OSError in ftphandler test. Only URLError is raised in urllib.request module. (#918)
---

diff --git a/Lib/test/test_urllib2.py b/Lib/test/test_urllib2.py
index 308acb3724..b537fca3c3 100644
--- a/Lib/test/test_urllib2.py
+++ b/Lib/test/test_urllib2.py
@@ -830,7 +830,6 @@ class HandlerTests(unittest.TestCase):
         for url, ftp in [
             ("file://ftp.example.com//foo.txt", False),
             ("file://ftp.example.com///foo.txt", False),
-# XXXX bug: fails with OSError, should be URLError
             ("file://ftp.example.com/foo.txt", False),
             ("file://somehost//foo/something.txt", False),
             ("file://localhost//foo/something.txt", False),
@@ -839,7 +838,7 @@ class HandlerTests(unittest.TestCase):
             try:
                 h.file_open(req)
             # XXXX remove OSError when bug fixed
-            except (urllib.error.URLError, OSError):
+            except urllib.error.URLError:
                 self.assertFalse(ftp)
             else:
                 self.assertIs(o.req, req)
@@ -1689,7 +1688,6 @@ class HandlerTests(unittest.TestCase):
         self.assertTrue(conn.fakesock.closed, "Connection not closed")
 
 
-
 class MiscTests(unittest.TestCase):
 
     def opener_has_handler(self, opener, handler_class):