From: Chris Hofstaedtler <chris.hofstaedtler@deduktiva.com>
Date: Wed, 6 Dec 2017 09:44:08 +0000 (+0100)
Subject: Drop useless if branch
X-Git-Tag: dnsdist-1.3.0~205^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ed2ff96ed209bb455d5fcef73798e7dfb1b90fcc;p=pdns

Drop useless if branch
---

diff --git a/pdns/misc.cc b/pdns/misc.cc
index d355324d5..88e05802e 100644
--- a/pdns/misc.cc
+++ b/pdns/misc.cc
@@ -719,9 +719,7 @@ int makeIPv6sockaddr(const std::string& addr, struct sockaddr_in6* ret)
     if(pos == string::npos)
       return -1;
     ourAddr.assign(addr.c_str() + 1, pos-1);
-    if (pos + 1 == addr.size()) {
-      port = 0;
-    } else {
+    if (pos + 1 != addr.size()) { // complete after ], no port specified
       if (pos + 2 > addr.size() || addr[pos+1]!=':')
         return -1;
       try {