From: Jeff King <peff@peff.net>
Date: Wed, 25 Mar 2015 05:25:55 +0000 (-0400)
Subject: perf-lib: fix ignored exit code inside loop
X-Git-Tag: v2.4.0-rc0~1^2~7
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ecb590a9de231a3312527da023cd5b60328ae22e;p=git

perf-lib: fix ignored exit code inside loop

When copying the test repository, we try to detect whether
the copy succeeded. However, most of the heavy lifting is
done inside a for loop, where our "break" will lose the exit
code of the failing "cp". We can take advantage of the fact
that we are in a subshell, and just "exit 1" to break out
with a code.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/t/perf/perf-lib.sh b/t/perf/perf-lib.sh
index a8c9574291..5cf74eddec 100644
--- a/t/perf/perf-lib.sh
+++ b/t/perf/perf-lib.sh
@@ -91,7 +91,7 @@ test_perf_create_repo_from () {
 				*/objects|*/hooks|*/config)
 					;;
 				*)
-					cp -R "$stuff" . || break
+					cp -R "$stuff" . || exit 1
 					;;
 			esac
 		done &&