From: Raymond Hettinger <python@rcn.com>
Date: Tue, 23 Jun 2009 21:27:39 +0000 (+0000)
Subject: Issue 6305: Clarify error message for large arguments to itertools.islice().
X-Git-Tag: v3.1~18
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ec7bfb314c9f43fbb5bc51ad0f4e20dff528db8f;p=python

Issue 6305: Clarify error message for large arguments to itertools.islice().
---

diff --git a/Modules/itertoolsmodule.c b/Modules/itertoolsmodule.c
index f1e76e2ba9..732bcd9fc2 100644
--- a/Modules/itertoolsmodule.c
+++ b/Modules/itertoolsmodule.c
@@ -1137,7 +1137,7 @@ islice_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
 				if (PyErr_Occurred())
 					PyErr_Clear();
 				PyErr_SetString(PyExc_ValueError,
-				   "Stop argument for islice() must be a non-negative integer or None.");
+				   "Stop argument for islice() must be None or an integer: 0 <= x <= maxsize.");
 				return NULL;
 			}
 		}
@@ -1152,14 +1152,14 @@ islice_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
 				if (PyErr_Occurred())
 					PyErr_Clear();
 				PyErr_SetString(PyExc_ValueError,
-				   "Stop argument for islice() must be a non-negative integer or None.");
+				   "Stop argument for islice() must be None or an integer: 0 <= x <= maxsize.");
 				return NULL;
 			}
 		}
 	}
 	if (start<0 || stop<-1) {
 		PyErr_SetString(PyExc_ValueError,
-		   "Indices for islice() must be non-negative integers or None.");
+		   "Indices for islice() must be None or an integer: 0 <= x <= maxsize.");
 		return NULL;
 	}