From: John McCall <rjmccall@apple.com>
Date: Thu, 1 Dec 2016 23:51:30 +0000 (+0000)
Subject: Struct GEPs must use i32, not whatever size_t is.  It should be safe
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ec5f181adcdc11d65b8f79f7a12a36258a68a10f;p=clang

Struct GEPs must use i32, not whatever size_t is.  It should be safe
to do this unconditionally, given that the indices will always be small
constant integers anyway.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@288440 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/CodeGen/ConstantBuilder.h b/lib/CodeGen/ConstantBuilder.h
index 6c5a5e515d..40b34a9d61 100644
--- a/lib/CodeGen/ConstantBuilder.h
+++ b/lib/CodeGen/ConstantBuilder.h
@@ -248,11 +248,13 @@ public:
       // Otherwise, add an index to drill into the first level of pointer. 
       } else {
         assert(indices.empty());
-        indices.push_back(llvm::ConstantInt::get(Builder.CGM.SizeTy, 0));
+        indices.push_back(llvm::ConstantInt::get(Builder.CGM.Int32Ty, 0));
       }
 
       assert(position >= Begin);
-      indices.push_back(llvm::ConstantInt::get(Builder.CGM.SizeTy,
+      // We have to use i32 here because struct GEPs demand i32 indices.
+      // It's rather unlikely to matter in practice.
+      indices.push_back(llvm::ConstantInt::get(Builder.CGM.Int32Ty,
                                                position - Begin));
     }
   };